Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 42 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Tests analytics

Total tests: 53
Passed tests: 26
Skipped tests: 1
Affected tests: 26

Action taken

Get to know how VCR tests work

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGooglePubsubSubscription_basic[Debug log]
TestAccDataSourceGooglePubsubSubscription_optionalProject[Debug log]
TestAccPubsubSubscriptionBigQuery_serviceAccount[Debug log]
TestAccPubsubSubscriptionBigQuery_update[Debug log]
TestAccPubsubSubscriptionCloudStorage_serviceAccount[Debug log]
TestAccPubsubSubscriptionCloudStorage_updateAvro[Debug log]
TestAccPubsubSubscriptionCloudStorage_updateText[Debug log]
TestAccPubsubSubscriptionIamBinding[Debug log]
TestAccPubsubSubscriptionIamMember[Debug log]
TestAccPubsubSubscriptionIamPolicy[Debug log]
TestAccPubsubSubscription_emptyRetryPolicy[Debug log]
TestAccPubsubSubscription_emptyTTL[Debug log]
TestAccPubsubSubscription_filter[Debug log]
TestAccPubsubSubscription_pollOnCreate[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionDeadLetterExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPullFilterExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushBqServiceAccountExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushExample[Debug log]
TestAccPubsubSubscription_push[Debug log]
TestAccPubsubSubscription_pushNoWrapper[Debug log]
TestAccPubsubSubscription_pushNoWrapperEmpty[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPubsubSubscription_pubsubSubscriptionPushBqExample[Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushBqTableSchemaExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 42 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Tests analytics

Total tests: 55
Passed tests: 52
Skipped tests: 1
Affected tests: 2

Action taken

Get to know how VCR tests work

🟢 Tests passed during RECORDING mode:
TestAccPubsubSubscription_pubsubSubscriptionPushBqExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushBqTableSchemaExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 48 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 48 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

Tests analytics

Total tests: 55
Passed tests: 54
Skipped tests: 1
Affected tests: 0

🟢 All tests passed!

View the build log

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 48 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 48 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 15 insertions(+), 6 deletions(-))

Tests analytics

Total tests: 55
Passed tests: 54
Skipped tests: 1
Affected tests: 0

🟢 All tests passed!

View the build log

It looks like send_empty_value means that the nil value also needs to be included in TGC tests.

Ah right, thanks. Updated and all tests are passing.

I'm not 100% clear on why we needed to change these tests but not the existing tests here however. send_empty_value is only supposed to send empty values to the API if they are explicitly set in the user config but they were not in the affected TGC tests.

As long as that's the same for the API as not sending the field, this should be fine. Let me know!

Yeah it shouldn't be an issue for the API (as evidenced by the existing acceptance tests passing). I was just concerned about potentially breaking folks' Terraform code, but I don't think that will be a problem either.